Skip to content

Added option for computing anti-stabilizing solutions of Riccati equations#281

Merged
murrayrm merged 6 commits into
python-control:masterfrom
dbankmann:master
Apr 7, 2019
Merged

Added option for computing anti-stabilizing solutions of Riccati equations#281
murrayrm merged 6 commits into
python-control:masterfrom
dbankmann:master

Conversation

@dbankmann

Copy link
Copy Markdown
Contributor

Sometimes also anti-stabilizing solutions of Riccati equations are of interest. The slicot routine offers to compute these solutions, so I added an option in the care and dare routine, which both default back to the stabilizing case.

@coveralls

coveralls commented Mar 21, 2019

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.04%) to 78.343% when pulling be598c1 on dbacc:master into 31e6944 on python-control:master.

@moorepants

Copy link
Copy Markdown

Can you please add unit tests to demonstrate the new functionality?

@dbankmann

Copy link
Copy Markdown
Contributor Author

Sure, done ;)

@murrayrm

Copy link
Copy Markdown
Member

Thanks for your contribution! The unit test needs to go in control/tests and use the unittest framework. I suggest adding this to statefbk-test.py since that is where other unit tests associated with controller synthesis currently live.

@dbankmann

Copy link
Copy Markdown
Contributor Author

now it should be at the correct location ;)

btw. Why is @coveralls telling that coverage decreased?

@murrayrm

Copy link
Copy Markdown
Member

@dbacc Can you merge changes from latest master to get Travis CI working again (see PR #280 for more info). Thanks.

@murrayrm

murrayrm commented Apr 6, 2019

Copy link
Copy Markdown
Member

Changes look good. Will include in 0.8.2 release after verifying there are no conflicts.

@murrayrm murrayrm added this to the 0.8.2 milestone Apr 6, 2019
@murrayrm murrayrm merged commit 1dd0ca2 into python-control:master Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants