Skip to content

install scikit-build for testing with slycot#280

Merged
murrayrm merged 3 commits into
python-control:masterfrom
repagh:install-scikit-for-travis
Mar 26, 2019
Merged

install scikit-build for testing with slycot#280
murrayrm merged 3 commits into
python-control:masterfrom
repagh:install-scikit-for-travis

Conversation

@repagh

@repagh repagh commented Mar 19, 2019

Copy link
Copy Markdown
Member

We need scikit-build when building and testing with slycot, should solve the issue with PR #276

@repagh

repagh commented Mar 19, 2019

Copy link
Copy Markdown
Member Author

Why doesn't this build on Travis? More patience needed?

@repagh repagh closed this Mar 19, 2019
@repagh repagh reopened this Mar 19, 2019
@murrayrm

Copy link
Copy Markdown
Member

I tried this out on my version of the repository and as soon as I merged it into a branch that used to be calling Travis CI, it stopped running Travis CI tests.

It looks like the problem is that there is a parsing error. If I look at the request history on my local branch, I see the following error:

Could not parse murrayrm/python-control/.travis.yml@b35def48d67bbe27

@repagh

repagh commented Mar 25, 2019

Copy link
Copy Markdown
Member Author

@murrayrm : thanks for the hint!
That solved it.

@coveralls

coveralls commented Mar 25, 2019

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 78.383% when pulling 1453385 on repagh:install-scikit-for-travis into 31e6944 on python-control:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants