Fix cleanup action for already merged pull requests#9133
Open
perlan wants to merge 1 commit into
Open
Conversation
Member
|
Thanks for the pullrequest, I would need to test it because it touches a critical part of Updatecli which is difficult to test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9003
This pull request ensure that the CleanAction does not fail if the pull request is auto-merged in CreateAction by using merge.strategy: client in combination with merge.after: 0s.
In my efforts to auto-merge a pull request I tested both auto and client strategies but had no success with either. Looking through the code I actually think that this fix is relevant to auto-merging via server-side merging as well, but I haven't tested that use-case.
Test
There is currently no test provided since the fix is a one-liner and adding a test requires refactoring more code. I did an attempt to create a test case that changes the query struct to a type. If that's fine, I can provide a test-case as well.
Additional Information
Checklist
Tradeoff
Potential improvement