fix: handle skipped condition dependencies in target gating#8426
Merged
olblak merged 11 commits intoApr 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates target gating so that condition dependencies must explicitly succeed (not be skipped) before a dependent target can run, addressing #7918.
Changes:
- Update
shouldSkipResourceto treat non-SUCCESScondition dependency results as blocking forANDgating. - Add a
TestRunTargetcase for a target depending on multiple conditions to ensure it is skipped when prerequisites don’t succeed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/core/pipeline/utils.go | Tightens AND dependency gating for condition prerequisites to require explicit SUCCESS. |
| pkg/core/pipeline/targets_test.go | Adds a regression test to ensure a target is skipped when condition prerequisites don’t succeed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@copilot apply changes based on the comments in this thread |
Member
|
Thank you for the pullrequest, I'll try to review it soon |
Signed-off-by: Olblak <[email protected]>
…b.com:nickzerjeski/updatecli into fix-conditional-target-dependson-skipped-7918
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7918
Ensure AND dependency evaluation does not treat skipped conditions as successful prerequisites. A target depending on conditions should only run when those condition dependencies explicitly succeed.
Test
To test this pull request, you can run the following commands:
Additional Information
Checklist
Tradeoff
conditiondependencies only; existing source/target dependency semantics are unchanged.Potential improvement
shouldSkipResourceunit test table covering all result/operator/category combinations for stronger behavior guarantees.