Fix YugabyteDB CI by adding ysql_yb_enable_listen_notify flag#1345
Open
tlmorgan24 wants to merge 2 commits into
Open
Fix YugabyteDB CI by adding ysql_yb_enable_listen_notify flag#1345tlmorgan24 wants to merge 2 commits into
tlmorgan24 wants to merge 2 commits into
Conversation
… LISTEN and NOTIFY statements are enabled
884081d to
ae78127
Compare
ae78127 to
376b9d4
Compare
mrigger
reviewed
Jun 19, 2026
| docker run -d --name yugabyte -p7000:7000 -p9000:9000 -p5433:5433 -p9042:9042 yugabytedb/yugabyte:latest bin/yugabyted start --daemon=false | ||
| docker run -d --name yugabyte -p7000:7000 -p9000:9000 -p5433:5433 -p9042:9042 yugabytedb/yugabyte:latest bin/yugabyted start --daemon=false --tserver_flags="ysql_yb_enable_listen_notify=true" --master_flags="ysql_yb_enable_listen_notify=true" | ||
| until pg_isready -h localhost -p 5433; do sleep 1; done | ||
| until nc -z localhost 9042; do sleep 1; done |
Contributor
There was a problem hiding this comment.
Is this waiting loop also needed?
Collaborator
Author
There was a problem hiding this comment.
It is not related to the ysql_yb_enable_listen_notify fix, but it is another robustness improvement to the YugabyteDB CI.
The CI previously had only until pg_isready -h localhost -p 5433; do sleep 1; done, which confirms YSQL on port 5433 is up, but does not necessarily imply YCQL on port 9042 is up (which gets tested in TestYCQL). So without the additional wait, it is possible for TestYCQL to fail due to connection refused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The YugabyteDB CI job was failing because SQLancer generates
LISTEN,NOTIFY, andUNLISTENstatements, but YugabyteDB has this feature disabled by default. This caused anAssertionErroreach time one of these statements was executed, terminating the test run.The fix enables the
ysql_yb_enable_listen_notifyruntime flag on both the tserver and master when starting YugabyteDB in CI, allowing these statements to execute as intended.Changes
.github/workflows/main.yml: Pass--tserver_flagsand--master_flagstoyugabyted startto enableysql_yb_enable_listen_notify