You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It wasn't the actual problem there, with control.matlab.wrappers.rlocus not being called (rather control.rlocus.rlocus = control.rlocus.root_locus_plot), but still this does forward kwargs to that function which is expecting gains rather than klist or kvect (though it does have a control._process_legacy_keyword in place to catch the latter).
Thanks, @gdmcbain ! While reviewing this, I noticed another kvect in the same docstring, so I fixed it, too.
By the way, it looks like the email address you are using in the commit is not associated with your GitHub account because your commit appears without an avatar above. Is that intentional, or did you want to use a different address?
By the way, it looks like the email address you are using in the commit is not associated with your GitHub account because your commit appears without an avatar above. Is that intentional, or did you want to use a different address?
Oops. I assume it's too late to fix now; never mind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #998.
It wasn't the actual problem there, with
control.matlab.wrappers.rlocusnot being called (rathercontrol.rlocus.rlocus = control.rlocus.root_locus_plot), but still this does forward kwargs to that function which is expectinggainsrather thanklistorkvect(though it does have acontrol._process_legacy_keywordin place to catch the latter).Feel free to ignore or use this.