Skip to content

allow float precision in result assertions#615

Merged
bnavigator merged 3 commits into
python-control:masterfrom
bnavigator:py39-float-tests
Apr 29, 2021
Merged

allow float precision in result assertions#615
bnavigator merged 3 commits into
python-control:masterfrom
bnavigator:py39-float-tests

Conversation

@bnavigator

@bnavigator bnavigator commented Apr 24, 2021

Copy link
Copy Markdown
Contributor

Fix the current CI with Conda Python 3.9 libraries fail.

@coveralls

coveralls commented Apr 24, 2021

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 89.476% when pulling 8a56d67 on bnavigator:py39-float-tests into e81f648 on python-control:master.

@bnavigator bnavigator changed the title allow float precision in test_damp allow float precision in result assertions Apr 24, 2021
@bnavigator

Copy link
Copy Markdown
Contributor Author

StateSpace matrices are always of dtype float (or complex, if #484 ever gets adopted), so comparing them to integer reference values can have a float precision error.

Not necessarily true for TransferFunction right now, but keep the same logic.

@bnavigator

Copy link
Copy Markdown
Contributor Author

Merging now, so that other PRs can be checked properly again.

@bnavigator bnavigator merged commit a6a5bee into python-control:master Apr 29, 2021
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
@bnavigator bnavigator deleted the py39-float-tests branch February 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants