Preserve signal names in scalar LTI operations#1228
Open
marko1olo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #902.
This preserves named input/output metadata when linear systems go through interface-preserving scalar operations:
-sys,control.negate(sys))sys * k,control.series(k, sys))k * sys,control.series(sys, k))The change covers both
StateSpaceandTransferFunction. ForStateSpace, state labels are preserved as well because the state vector is unchanged by these operations.I intentionally kept this PR narrow and did not change matrix multiplication or general system-to-system interconnections, since those cases can alter the external interface and need a separate naming policy.
Local validation:
python -m pytest -p no:cacheprovider control\tests\namedio_test.py::test_named_scalar_operations_preserve_signal_names -q-> 12 passedpython -m pytest -p no:cacheprovider control\tests\namedio_test.py -q-> 22 passed, 10 skippedpython -m pytest -p no:cacheprovider control\tests\statesp_test.py -q-> 828 passed, 112 skipped, 1 xfailedpython -m pytest -p no:cacheprovider control\tests\xferfcn_test.py -q-> 145 passed, 4 skippedpython -m pytest -p no:cacheprovider control\tests\bdalg_test.py -q-> 48 passedpython -m ruff check control\statesp.py control\xferfcn.py control\tests\namedio_test.py-> passedpython -m compileall -q control-> passed