Fix zero-input interconnect D matrix shape#1221
Merged
murrayrm merged 1 commit intoJun 8, 2026
Merged
Conversation
Preserve explicitly shaped empty state-space matrices so linearized interconnections with zero inputs and nonzero outputs keep a (noutputs, 0) D matrix. Co-authored-by: OpenAI Codex <[email protected]>
|
coverage: 94.736%. remained the same — marko1olo:fix-zero-input-interconnect-dmatrix into python-control:main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1176.
Summary
(1, 0)in_ssmatrixinterconnect()to linearize systems with zero inputs and one or more outputs without collapsingDto(0, 0)Validation
python -m pytest control\tests\interconnect_test.py -q -k "zero_input_one_output or linear_interconnect or interconnect_series"python -m pytest control\tests\statesp_test.py -qpython -m ruff check control\statesp.py control\tests\interconnect_test.pypython -m compileall -q control\statesp.py control\tests\interconnect_test.pygit diff --checkAI-assisted contribution: implemented with OpenAI Codex and reviewed locally before submission.