fix(conn): Removed automatic conn_uid assignment#1551
Merged
Conversation
Contributor
Author
|
@tillkruss The general code coverage was slightly decreased because a line of code was removed |
tillkruss
approved these changes
Jun 4, 2025
tillkruss
left a comment
Member
There was a problem hiding this comment.
Do we need to port this to v3.x?
Contributor
Author
|
@tillkruss Absolutely, I will take care of this |
htemelski
approved these changes
Jun 5, 2025
vladvildanov
added a commit
that referenced
this pull request
Jun 5, 2025
* fix(conn): Removed automatic conn_uid assignment * Restrict redis version * Updated CHANGELOG.md * Added test case * Update CHANGELOG.md --------- Co-authored-by: Till Krüss <[email protected]>
Merged
vladvildanov
added a commit
that referenced
this pull request
Jun 5, 2025
* fix(conn): Removed automatic conn_uid assignment (#1551) * fix(conn): Removed automatic conn_uid assignment * Restrict redis version * Updated CHANGELOG.md * Added test case * Update CHANGELOG.md --------- Co-authored-by: Till Krüss <[email protected]> * Removed duplicated disconnect * Updated CHANGELOg.md --------- Co-authored-by: Till Krüss <[email protected]>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1539
Automatic
conn_uidassignment was added as a part of #1512, but it leads to a connection spikes in case if failover happens and connections is recreated by client. Since,conn_uidis a parameter option it must be assigned by user instead to avoid sharing of the socket between different clients within a single process.