Use a media icon for the Images Preview editor label#320951
Merged
dmitrivMS merged 8 commits intoJun 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a themed icon for the Image Carousel editor input so the editor label can display a consistent icon.
Changes:
- Registers a new theme icon for the image carousel editor label.
- Overrides
getIcon()onImageCarouselEditorInputto return the registered icon.
dmitrivMS
previously approved these changes
Jun 11, 2026
mjbvz
previously approved these changes
Jun 11, 2026
auto-merge was automatically disabled
June 12, 2026 14:30
Head branch was pushed to by a user without write access
Contributor
Author
|
@dmitrivMS Apologies — I merged main locally and pushed while debugging the flaky testcase which was failing once for macos and twice windows for chat session. Could you re-approve when you get a chance? (the diff is unchanged) |
dmitrivMS
approved these changes
Jun 12, 2026
Yoyokrazy
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #304121
Problem
The Images Preview editor shows the default text-file icon in its modal header label, which doesn't represent image content:

Fix
ImageCarouselEditorInputnever overrodegetIcon(), so the label fell back to the default file icon. This change registers a dedicated icon and returns it from the input, following the same pattern used by other editor inputs (searchEditorInput.ts,chatDebugEditorInput.ts,extensionsInput.ts, etc.):Notes:
$(file-media)is proposed as the icon — happy to switch to a different codicon if preferred.registerIconkeeps the icon overridable by product icon themes, consistent with the other editor label icons.modalEditorPart.ts) already rendersgetIcon()via the resource label, and the icon is sized by the shared.monaco-icon-labelstyles like every other editor icon.Before / After
Before:

After:

