Loops: while and for by vahmelk99 · Pull Request #84 · javascript-tutorial/hy.javascript.info

vahmelk99 · 2021-08-21T12:46:57Z

No description provided.

bugron

Overall looks good just a few comments to address. Besides those comments while you're resolving merge conflicts I'll get to reviewing the main article.

javascript-translate-bot · 2021-08-21T14:08:02Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: Arsen Melikyan <[email protected]>

…on.md Co-authored-by: Arsen Melikyan <[email protected]>

Co-authored-by: Arsen Melikyan <[email protected]>

vahmelk99 · 2021-08-21T14:21:48Z

Thanks for the review)

vahmelk99 · 2021-08-21T14:21:54Z

/done

bugron

Let's address a few more comments and we're good to go.

javascript-translate-bot · 2021-08-21T15:27:28Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: Arsen Melikyan <[email protected]>

vahmelk99 · 2021-08-21T15:36:47Z

/done

bugron · 2021-08-21T15:37:51Z

This is awesome! Thanks @vahmelk99 for all your hard work. It is my pleasure to collaborate with you. Way to go! Merged.

javascript-translate-bot · 2021-08-21T15:38:01Z

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

vahmelk99 added 5 commits August 17, 2021 22:28

article while loops

7af7b49

break translated

8f4f536

article done

794be86

ex1 translated

371b28c

exs translated

88e3ddd

javascript-translate-bot added the review needed label Aug 21, 2021

javascript-translate-bot requested a review from a team August 21, 2021 12:46

javascript-translate-bot mentioned this pull request Aug 21, 2021

Armenian Translation Progress #1

Open

vahmelk99 commented Aug 21, 2021

View reviewed changes

Comment thread 1-js/02-first-steps/13-while-for/article.md Outdated

Update 1-js/02-first-steps/13-while-for/article.md

0ae628f

bugron requested changes Aug 21, 2021

View reviewed changes

javascript-translate-bot added changes requested and removed review needed labels Aug 21, 2021

vahmelk99 and others added 7 commits August 21, 2021 18:08

Update 1-js/02-first-steps/13-while-for/2-which-value-while/solution.md

feb54b2

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/5-replace-for-while/task.md

3cc0808

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/6-repeat-until-correct/soluti…

998b003

…on.md Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/7-list-primes/solution.md

763c6f2

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/7-list-primes/task.md

ffb0e12

Co-authored-by: Arsen Melikyan <[email protected]>

7th sol fix

38730de

Merge branch 'master' into master

9bb925b

javascript-translate-bot added review needed and removed changes requested labels Aug 21, 2021

javascript-translate-bot requested a review from a team August 21, 2021 14:21

bugron requested changes Aug 21, 2021

View reviewed changes

javascript-translate-bot added changes requested and removed review needed labels Aug 21, 2021

vahmelk99 and others added 18 commits August 21, 2021 19:31

Update 1-js/02-first-steps/13-while-for/7-list-primes/solution.md

5806f13

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/article.md

e653e50

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/article.md

6f701c6

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/article.md

df1e71f

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/article.md

9f90054

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/article.md

14c423e

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/article.md

4ccbb8f

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/article.md

6482c5d

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/article.md

3f2c9c8

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/article.md

132ebde

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/article.md

8cef7f2

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/article.md

4927262

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/article.md

a84d5d3

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/article.md

74574c7

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/article.md

a76316c

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/article.md

b032a1f

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/article.md

6ba30b1

Co-authored-by: Arsen Melikyan <[email protected]>

Update 1-js/02-first-steps/13-while-for/article.md

2de07d1

Co-authored-by: Arsen Melikyan <[email protected]>

javascript-translate-bot added review needed and removed changes requested labels Aug 21, 2021

javascript-translate-bot requested a review from a team August 21, 2021 15:36

bugron merged commit dd52f90 into javascript-tutorial:master Aug 21, 2021

Uh oh!

Conversation

vahmelk99 commented Aug 21, 2021

Uh oh!

Uh oh!

bugron left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 21, 2021

Uh oh!

vahmelk99 commented Aug 21, 2021

Uh oh!

vahmelk99 commented Aug 21, 2021

Uh oh!

bugron left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 21, 2021

Uh oh!

vahmelk99 commented Aug 21, 2021

Uh oh!

bugron commented Aug 21, 2021

Uh oh!

javascript-translate-bot commented Aug 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bugron left a comment •

edited

Loading