Skip to content

Data types#77

Merged
bugron merged 8 commits into
javascript-tutorial:masterfrom
arthur-gyulabyan:master
Jul 11, 2021
Merged

Data types#77
bugron merged 8 commits into
javascript-tutorial:masterfrom
arthur-gyulabyan:master

Conversation

@arthur-gyulabyan

Copy link
Copy Markdown
Contributor

Data types section translated.

@javascript-translate-bot

Copy link
Copy Markdown

Error: the article already has PR number in the Progress Issue #1, it's 77 ⁉️

@CLAassistant

CLAassistant commented Jul 9, 2021

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@bugron

bugron commented Jul 10, 2021

Copy link
Copy Markdown
Contributor

@arthur-gyulabyan thanks for the PR. I'll review it soon. Keep up the good work!

@arthur-gyulabyan

Copy link
Copy Markdown
Contributor Author

@bugron thank you for response.

@bugron

bugron commented Jul 11, 2021

Copy link
Copy Markdown
Contributor

This looks great. I'll be reviewing your translations today. For future let's keep the one article - one PR principle.

@arthur-gyulabyan

Copy link
Copy Markdown
Contributor Author

Oh, sorry for that mistake. I'll follow the principle in further PRs.

@bugron bugron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arthur-gyulabyan thanks again for the PR. I am amazed by the quality of the translation, really!
Please do not get discouraged by the number of comments! Except for those new line comments there are just a few things to address and we'll be ready to merge this.
Way to go!

Comment thread 1-js/02-first-steps/05-types/article.md Outdated
Comment thread 1-js/02-first-steps/05-types/article.md Outdated
Comment thread 1-js/02-first-steps/05-types/article.md Outdated
Comment thread 1-js/02-first-steps/05-types/article.md Outdated
Comment thread 1-js/02-first-steps/05-types/article.md Outdated
Comment thread 1-js/02-first-steps/06-alert-prompt-confirm/article.md Outdated
Comment thread 1-js/02-first-steps/06-alert-prompt-confirm/article.md Outdated
Comment thread 1-js/02-first-steps/06-alert-prompt-confirm/article.md Outdated
Comment thread 1-js/02-first-steps/06-alert-prompt-confirm/article.md Outdated
Comment thread 1-js/02-first-steps/06-alert-prompt-confirm/article.md Outdated
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@arthur-gyulabyan

Copy link
Copy Markdown
Contributor Author

@bugron thank you for review! The issue with new lines occurred because of my editor's settings. I fixed it, so now everything is okay. I also fixed typos and other bugs.

@arthur-gyulabyan

Copy link
Copy Markdown
Contributor Author

/done

@bugron bugron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bugron

bugron commented Jul 11, 2021

Copy link
Copy Markdown
Contributor

Thanks for your first PR! Merging and looking forward to your future contributions. 🎉🎉🎉

@bugron bugron merged commit df5f520 into javascript-tutorial:master Jul 11, 2021
@javascript-translate-bot

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@javascript-translate-bot

Copy link
Copy Markdown

Error: the article already translated in the Progress Issue #1 ⁉️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants