Skip to content

Function expressions#82

Merged
otmon76 merged 8 commits into
javascript-tutorial:masterfrom
otmon76:1.2.16
Jul 25, 2022
Merged

Function expressions#82
otmon76 merged 8 commits into
javascript-tutorial:masterfrom
otmon76:1.2.16

Conversation

@otmon76

@otmon76 otmon76 commented Apr 18, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Apr 18, 2022
@javascript-translate-bot javascript-translate-bot requested a review from a team April 18, 2022 20:40
@danipoma danipoma changed the title 1.2.16 Function expressions May 1, 2022
Comment thread 1-js/02-first-steps/16-function-expressions/article.md Outdated
Comment thread 1-js/02-first-steps/16-function-expressions/article.md Outdated
Comment thread 1-js/02-first-steps/16-function-expressions/article.md Outdated

@danipoma danipoma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed two paragraphs since they were not in source files anymore and also changed some text without suggestion since it was clear translation inconsistency.

Please take a look on my suggestions.

@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Jul 24, 2022
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@otmon76

otmon76 commented Jul 25, 2022

Copy link
Copy Markdown
Contributor Author

"Removed two paragraphs since they were not in source files anymore and also changed some text without suggestion since it was clear translation inconsistency."
this is true, I didn't notice that the two paragraphs were removed

@otmon76 otmon76 merged commit 5a10b48 into javascript-tutorial:master Jul 25, 2022
@javascript-translate-bot

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@otmon76

otmon76 commented Jul 25, 2022

Copy link
Copy Markdown
Contributor Author

I am sorry I mistakenly merged it but the suggestions were applied.

@otmon76

otmon76 commented Jul 25, 2022

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jul 25, 2022
@javascript-translate-bot javascript-translate-bot requested a review from a team July 25, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review needed Review needed, please approve or request changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants