Add ora_db_unique_name Terraform variable to set DB_UNIQUE_NAME#436
Merged
Conversation
Add ora_db_unique_name Terraform variable to set DB_UNIQUE_NAME
Collaborator
Author
|
@mfielding nit addressed |
mfielding
approved these changes
Jun 16, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMafra, mfielding The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description:
Add terraform support for setting the Oracle database unique name (DB_UNIQUE_NAME).
Pass the new
--ora-db-unique-nameflag from terraform through toinstall-oracle.sh.This brings the terraform layer to parity with
install-oracle.sh, which alreadysupports
--ora-db-unique-namefor both Primary and Standby databases.Solution Overview:
Implements
ora_db_unique_namesupport on the toolkit terraform configurationOptional variable; works for both Primary and Standby databases. When left empty the
existing ansible default applies (
db_namefor Primary,db_name_sfor Standby)Test Commands:
Test Prep:
The following variable can be provided to terraform (optional)
An example value was added to the
terraform.tfvars.*.examplefilesTest 1: details:
Terraform renders the
install-oracle.shcommand with--ora-db-unique-namewhen thevariable is set, and omits it when left empty.
The implementation should be transparent for other components of toolkit
Expected Results:
When
ora_db_unique_nameis set, the generatedinstall-oracle.shcommand includes--ora-db-unique-name <value>, and the database comes up with the expectedDB_UNIQUE_NAMEfor both Primary and Standby installs.oratk59-17 terraform test results
database values