Skip to content

A few fixes for a RHEL8 cloud install#148

Merged
mfielding merged 2 commits into
masterfrom
el8cloud
Sep 7, 2023
Merged

A few fixes for a RHEL8 cloud install#148
mfielding merged 2 commits into
masterfrom
el8cloud

Conversation

@mfielding

@mfielding mfielding commented Jul 17, 2023

Copy link
Copy Markdown
Member

Putting together a few bugfixes while testing RHEL8 in cloud:

  • Supporting hostnames in addition to IP addresses for --instance-ip-addr
  • Disabling GPG checks on cvuqdisk (which is unsigned in the Oracle install)
fatal: [mfielding-bench1]: FAILED! => {"changed": false, "msg": "Failed to validate GPG signature for cvuqdisk-1.0.10-1.x86_64: Package cvuqdisk-1.0.10-1.rpm is not signed"}
  • Adding the CV_ASSUME_DISTID for (MOS note 2878100.1) to single-instance GI installs, as they also run CVU. Also expanding the scope to all RedHat family OSes (including RHEL)
fatal: [mfielding-bench1]: FAILED! => {"changed": true, "cmd": ["/u01/app/19.3.0/grid/gridSetup.sh", "-ignorePrereqFailure", "-silent", "-responseFile", "/u01/oracle_install/grid_install.rsp", "-applyRU", "/u01/oracle_install/34773504/34762026", "-J-Doracle.install.mgmtDB=false", "-J-Doracle.install.mgmtDB.CDB=false", "-J-Doracle.install.crs.enableRemoteGIMR=false"], "delta": "0:00:02.566685", "end": "2023-07-17 18:56:01.452618", "failed_when_result": true, "msg": "non-zero return code", "rc": 255, "start": "2023-07-17 18:55:58.885933", "stderr": "", "stderr_lines": [], "stdout": "Preparing the home to patch...\nPreparing the home to apply the patch failed. For details look at the logs from /tmp/GridSetupActions2023-07-17_06-55-58PM/PatchActions/oraInventory/logs.\nThe log can be found at: /tmp/GridSetupActions2023-07-17_06-55-58PM/installerPatchActions_2023-07-17_06-55-58PM.log\nLaunching Oracle Grid Infrastructure Setup Wizard...\n\n[WARNING] [INS-08101] Unexpected error while executing the action at state: 'supportedOSCheck'\n   CAUSE: No additional information available.\n   ACTION: Contact Oracle Support Services or refer to the software manual.\n   SUMMARY:\n       - java.lang.NullPointerException\nMoved the install session logs to:\n /u01/app/oraInventory/logs/GridSetupActions2023-07-17_06-55-58PM", "stdout_lines": ["Preparing the home to patch...", "Preparing the home to apply the patch failed. For details look at the logs from /tmp/GridSetupActions2023-07-17_06-55-58PM/PatchActions/oraInventory/logs.", "The log can be found at: /tmp/GridSetupActions2023-07-17_06-55-58PM/installerPatchActions_2023-07-17_06-55-58PM.log", "Launching Oracle Grid Infrastructure Setup Wizard...", "", "[WARNING] [INS-08101] Unexpected error while executing the action at state: 'supportedOSCheck'", "   CAUSE: No additional information available.", "   ACTION: Contact Oracle Support Services or refer to the software manual.", "   SUMMARY:", "       - java.lang.NullPointerException", "Moved the install session logs to:", " /u01/app/oraInventory/logs/GridSetupActions2023-07-17_06-55-58PM"]}
  • Installing packages from both cloud and standalong Red Hat repos: in cloud, the repo has a different name; the toolkit enumerates this and this functionality used to work, but regressed at one point. Explicitly adding recognition of both repo types when installing packages
fatal: [mfielding-bench1]: FAILED! => {"changed": false, "failures": [["ls: cannot access '/usr/sbin/smartctl': No such file or directory", "/usr/sbin/smartctl not found.", "error: %prein(cvuqdisk-1.0.10-1.x86_64) scriptlet failed, exit status 1"]], "msg": "Failed to install some of the specified packages", "rc": 1, "results": []}

Sample output with changes applied:
https://gist.github.com/mfielding/b5b76eaafa61dddee20e94d3fd44e5b8

@mfielding
A few fixes for a RHEL8 cloud install
c2d37fd 
Putting together a few bugfixes while testing RHEL8 in cloud:

* Supporting hostnames in addition to IP addresses for
  `--instance-ip-addr`
* Disabling GPG checks on cvuqdisk (which is unsigned in the Oracle
  install)
* Adding the CV_ASSUME_DISTID for (MOS note 2878100.1) to
  single-instance GI installs, as they also run CVU.  Also expanding the
  scope to all RedHat family OSes (including RHEL)
* Installing packages from both cloud and standalong Red Hat repos:  in
  cloud, the repo has a different name;  the toolkit enumerates this and
  this functionality used to work, but regressed at one point.
  Explicitly adding recognition of both repo types when installing
  packages
@mfielding mfielding requested a review from jcnars July 17, 2023 21:08
@mfielding

mfielding commented Jul 17, 2023

Copy link
Copy Markdown
Member Author

/test bms-toolkit-install

1 similar comment
@mfielding

mfielding commented Sep 6, 2023

Copy link
Copy Markdown
Member Author

/test bms-toolkit-install

jcnars
jcnars reviewed Sep 7, 2023
View reviewed changes
Comment thread install-oracle.sh
INSTANCE_IP_ADDR="${INSTANCE_IP_ADDR}"
INSTANCE_IP_ADDR_PARAM='^((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)$'
INSTANCE_IP_ADDR_PARAM="[a-z0-9][a-z0-9\-\.]*"

@jcnars jcnars Sep 7, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will help if you leave maybe an inline comment with examples of what these Regexes evaluate to.

Also, if the new one bombed, do you think retaining the earlier one but commented out is a good idea?

@mfielding mfielding Sep 7, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a descriptive comment. In addition to being simpler, this new regex is a superset of the old; it should match any 0.0.0.0 style address, with admittedly looser checks.

@jcnars jcnars Sep 7, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

jcnars
jcnars reviewed Sep 7, 2023
View reviewed changes
Comment thread roles/rac-db-setup/tasks/rac-db-install.yml
line: "CV_ASSUME_DISTID=OEL7.8"
when:
- ansible_distribution == 'OracleLinux'
- ansible_os_family == 'RedHat'

@jcnars jcnars Sep 7, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon me, I am not entirely clear on the reason for this change.

@mfielding mfielding Sep 7, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CV_ASSUME_DISTID change is required to install 19.3 on any RedHat-like operating system, not just Oracle Linux (MOS note 2878100.1).

@jcnars jcnars Sep 7, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm

@google-oss-prow google-oss-prow Bot added the lgtm label Sep 7, 2023
@google-oss-prow

google-oss-prow Bot commented Sep 7, 2023

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcnars, mfielding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfielding mfielding merged commit fe3c3d8 into master Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jcnars jcnars jcnars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jcnars jcnars

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mfielding @jcnars