Firestore: Fix global refs exhaustion issue in Android#1364
Merged
Conversation
…d of Global [skip actions]
Integration test with FLAKINESS (succeeded after retry)Requested by @dconeybe on commit f2f99bb
Add flaky tests to go/fpl-cpp-flake-tracker |
wu-hui
approved these changes
Jun 30, 2023
wu-hui
left a comment
Contributor
There was a problem hiding this comment.
This is an impressive PR, I love how organized it is.
I left couple comments on potential improvements in some code comments, but LGTM overall, nice work!
wu-hui
approved these changes
Jun 30, 2023
tom-andersen
pushed a commit
that referenced
this pull request
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly fix the the global refs exhaustion issue tracked by firebase/firebase-unity-sdk#569, and reported in firebase/quickstart-unity#1303 and firebase/quickstart-unity#1193 (comment) (Googlers see b/251869890 for more details). Part 1, a partial mitigation, was #1111.
This PR supersedes, and builds upon the work done by @cherylEnkidu in, #1176.
Googlers see go/firestore-cpp-sdk-android-global-ref-exhaustion-bug and b/251869890 for more information.