Setup Desktop test workflow that detects C++ SDK breakage caused by iOS SDK changes by sunmou99 · Pull Request #1162 · firebase/firebase-cpp-sdk

sunmou99 · 2022-12-05T18:56:38Z

Description

Add nightly workflow that run firebase desktop tests against iOS tip-of-tree branch.
Also, generate the result report and send to Firestore Nightly Report.

Note: desktop build failed on Windows. Uploaded log files to the original ticket.

Other: Fix "build desktop script does not throw errors". e.g. https://github.com/firebase/firebase-cpp-sdk/actions/runs/3632775054/jobs/6129012424#step:14:1681

Testing

https://github.com/firebase/firebase-cpp-sdk/actions/runs/3635116249
report: #835

Type of Change

Place an x the applicable box:

Bug fix. Add the issue # below if applicable.
New feature. A non-breaking change which adds functionality.
Other, such as a build process or documentation change.

Notes

Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
Read the contribution guidelines CONTRIBUTING.md.
Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

github-actions · 2022-12-07T23:05:11Z

❌ Integration test FAILED

Requested by @sunmou99 on commit b07793a
Last updated: Tue Dec 27 17:28 PST 2022
View integration test log & download artifacts

Failures	Configs
firestore	[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target] (2 failed tests) QueryTest.TestListenUnlistenRelistenSequenceOfMirrorQueries ValidationTest.TransactionsRequireValidDocumentReferences [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target] (1 failed tests) TransactionTest.TestGetNonexistentDocumentThenFailPatch
gma	[TEST] [FAILURE] [iOS] [macos] [1/2 ios_device: ios_target] (2 failed tests) FirebaseGmaTest.TestRewardedAdLoad FirebaseGmaTest.TestRewardedAdLoadEmptyRequest
installations	[TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target] (1 failed tests) CRASH/TIMEOUT
messaging	[TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target] (1 failed tests) CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

dconeybe · 2022-12-15T01:27:43Z

@sunmou99 Could you re-trigger the test run that surfaced the Windows build error? I've pushed up a commit to this branch that may fix it by setting git's core.eol config setting to lf: e5a4993

dconeybe · 2022-12-15T18:59:58Z

@sunmou99 Could you re-trigger the test run that surfaced the Windows build error? I've pushed up a commit to this branch that may fix it by setting git's core.eol config setting to lf: e5a4993

@sunmou99 did this core.eol change help anything?

sunmou99 · 2022-12-15T19:04:10Z

@sunmou99 Could you re-trigger the test run that surfaced the Windows build error? I've pushed up a commit to this branch that may fix it by setting git's core.eol config setting to lf: e5a4993

@sunmou99 did this core.eol change help anything?

@dconeybe Yes, but the build jobs still failed for a different reason.
https://github.com/firebase/firebase-cpp-sdk/actions/runs/3707050079

LINK : fatal error LNK1104: cannot open file 'pthreads.lib' [D:\a\firebase-cpp-sdk\firebase-cpp-sdk\ta\firestore\iti\CMakeFiles\CMakeScratch\TryCompile-e6r1gy\cmTC_7308e.vcxproj]

dconeybe · 2022-12-16T01:49:41Z

Hmm. @sunmou99 @ehsannas what do you think about merging this PR with Windows disabled, and then we can work on fixing the windows build in a separate PR? It would be good to have _some_coverage. The marginal gain from adding Windows to the test matrix is quite small.

ehsannas · 2022-12-16T18:19:08Z

@dconeybe @sunmou99 yeah I think it's still valuable to enable these bots for Linux and macOS.

@dconeybe should we land your commit with the new git config too? or do you want to revert that?

dconeybe · 2022-12-16T18:43:29Z

@dconeybe @sunmou99 yeah I think it's still valuable to enable these bots for Linux and macOS.

@dconeybe should we land your commit with the new git config too? or do you want to revert that?

My commit should be reverted, since it didn't fix anything.

…errors." This reverts commit e5a4993.

sunmou99 · 2022-12-16T22:27:26Z

@dconeybe @sunmou99 yeah I think it's still valuable to enable these bots for Linux and macOS.
@dconeybe should we land your commit with the new git config too? or do you want to revert that?

My commit should be reverted, since it didn't fix anything.

reverted

sunmou99 added 4 commits November 30, 2022 16:06

test cmake build

c74af70

test against TIP

f63f53a

test desktop build

426b907

get error log

2887b95

sunmou99 added the skip-release-notes Skip release notes check label Dec 5, 2022

sunmou99 and others added 8 commits December 5, 2022 14:00

Merge branch 'main' into feature/against-ios-main

a5c9cca

update cmake flag

92e8762

get artifact

a4bcfc6

fix arch

57db77d

fix artifact name

a0c55eb

throw build desktop errors

99f15d6

add firestore test against tip report

a4b4c16

fix format

a215d48

sunmou99 changed the title ~~Desktop test against ios tip-of-tree~~ Setup Desktop test workflow that detects C++ SDK breakage caused by iOS SDK changes Dec 6, 2022

sunmou99 marked this pull request as ready for review December 6, 2022 22:54

sunmou99 added 2 commits December 6, 2022 17:04

fix format

abf075f

fix format

b92c670

sunmou99 requested a review from jonsimantov December 7, 2022 02:28

remove test code

6a3f513

sunmou99 requested a review from ehsannas December 7, 2022 02:30

sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Dec 7, 2022

github-actions Bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Dec 7, 2022

github-actions Bot added the tests: failed This PR's integration tests failed. label Dec 8, 2022

firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 8, 2022

sunmou99 added 2 commits December 12, 2022 13:36

disable windows desktop test when test against ios main branch

6c00fb0

update comment

4c8b470

sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Dec 12, 2022

github-actions Bot added the tests: in-progress This PR's integration tests are in progress. label Dec 12, 2022

github-actions Bot added the tests: failed This PR's integration tests failed. label Dec 13, 2022

firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 13, 2022

See if setting core.eol git config to lf fixes windows build errors.

e5a4993

dconeybe added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Dec 15, 2022

github-actions Bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Dec 15, 2022

github-actions Bot added the tests: failed This PR's integration tests failed. label Dec 15, 2022

firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 15, 2022

test against tip-of-tree

391d465

Merge branch 'main' into feature/against-ios-main

c7ecf4f

sunmou99 added 2 commits December 16, 2022 14:24

revert code

da6e7cc

Revert "See if setting core.eol git config to lf fixes windows build …

ec76846

…errors." This reverts commit e5a4993.

ehsannas approved these changes Dec 20, 2022

View reviewed changes

Merge branch 'main' into feature/against-ios-main

82d15f6

sunmou99 enabled auto-merge (squash) December 27, 2022 22:08

sunmou99 removed the tests: failed This PR's integration tests failed. label Dec 27, 2022

sunmou99 merged commit b07793a into main Dec 27, 2022

github-actions Bot added the tests: in-progress This PR's integration tests are in progress. label Dec 27, 2022

sunmou99 deleted the feature/against-ios-main branch December 27, 2022 23:14

github-actions Bot added the tests: failed This PR's integration tests failed. label Dec 28, 2022

firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 28, 2022

firebase locked and limited conversation to collaborators Jan 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup Desktop test workflow that detects C++ SDK breakage caused by iOS SDK changes#1162

Setup Desktop test workflow that detects C++ SDK breakage caused by iOS SDK changes#1162
sunmou99 merged 23 commits into
mainfrom
feature/against-ios-main

sunmou99 commented Dec 5, 2022 •

edited

Loading

Uh oh!

github-actions Bot commented Dec 7, 2022 •

edited

Loading

Uh oh!

dconeybe commented Dec 15, 2022

Uh oh!

dconeybe commented Dec 15, 2022

Uh oh!

sunmou99 commented Dec 15, 2022 •

edited

Loading

Uh oh!

dconeybe commented Dec 16, 2022

Uh oh!

ehsannas commented Dec 16, 2022

Uh oh!

dconeybe commented Dec 16, 2022

Uh oh!

sunmou99 commented Dec 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sunmou99 commented Dec 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Type of Change

Notes

Uh oh!

github-actions Bot commented Dec 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Integration test FAILED

Uh oh!

dconeybe commented Dec 15, 2022

Uh oh!

dconeybe commented Dec 15, 2022

Uh oh!

sunmou99 commented Dec 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dconeybe commented Dec 16, 2022

Uh oh!

ehsannas commented Dec 16, 2022

Uh oh!

dconeybe commented Dec 16, 2022

Uh oh!

sunmou99 commented Dec 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sunmou99 commented Dec 5, 2022 •

edited

Loading

github-actions Bot commented Dec 7, 2022 •

edited

Loading

sunmou99 commented Dec 15, 2022 •

edited

Loading